This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Improve dashboard/account charts and tooltips #2157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/improves some of the UI around charts for both the dashboard and the account view.
Fix the tooltip account value text on the tooltip to use

color-blackfor visibility in dark mode. I'm not sure if we want a different tooltip all-together on dark mode, but this is at least an incremental improvementChanges the circle outline on the tooltip to an arrow. I'm quite colorblind, and the small outline of a red/green circle is almost impossible for me to tell unless I zoom in really close. I think the arrows are a much better visual indicator

Simplifies and consolidates some of the logic/structure around the trend change line. Previously, the net worth chart was using the
_trend_changepartial, and the account page was rolling its own. This resulted in a few differences:Now, both charts use the same partial, which was also updated to include the
comparison labelin a consistent way. This also standardizes a bit of formatting here. The comparison label here is an optional parameter to support places that this partial is used without a comparison timeframe, e.g. the holdings drawer (see more below)Account trend change before/after:

Cleans up a few things on the holdings page and drawer:
uppercaseends up overriding most of these changes_trend_changepartial which is maybe a little misleading, but it doesn't pass a comparison label so there is novs.comparison. The@holding.trendobject here seems to automatically be set to have a start date since the beginning, and the range picker on the graph does not impact the holding page right now, so I think "Total Return" is more accurate"Adds some text to locales files to the net worth and account charts to remove hardcoded text (there are probably still lots of these, but again just some incremental changes)