Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 148 148
Lines 5171 5171
=======================================
Hits 4895 4895
Misses 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevenbal
reviewed
May 15, 2025
Collaborator
stevenbal
left a comment
stevenbal
left a comment
There was a problem hiding this comment.
When a new version of commonground-api-common is released, you can remove the git dependency from base.in and run bin/compile_dependencies.sh -P commonground-api-common==... to upgrade to that new version.
Also might be better to change the commit message to mention that you upgraded the library to version 2.x.x
TimdeBeer1
force-pushed
the
issue/change-default-filter-backend
branch
from
051d3e2 to
b42f73b
Compare
TimdeBeer1
force-pushed
the
issue/change-default-filter-backend
branch
from
3afbb3d to
c2dd91f
Compare
danielmursa-dev
force-pushed
the
issue/change-default-filter-backend
branch
from
c2dd91f to
4f0e9de
Compare
danielmursa-dev
force-pushed
the
issue/change-default-filter-backend
branch
from
4f0e9de to
7cd61a8
Compare
danielmursa-dev
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-klant#414
Changes
Changed default filter backend and used commonground-api-common branch:
maykinmedia/commonground-api-common#94