✨ [#538] Improve performance and add tests#596
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 94.77% 94.68% -0.09%
==========================================
Files 148 148
Lines 5164 5171 +7
==========================================
+ Hits 4894 4896 +2
- Misses 270 275 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
47c48ff to
a7b47a6
Compare
stevenbal
left a comment
There was a problem hiding this comment.
@danielmursa-dev the changes themselves looks good, but I can't see if the concurrent performance changed after them. Could you maybe reorder the commits to first add the performance tests, run them to see the current performance and then push the changes to see how they affect the response times?
|
In the meantime we'll probably have to wait until we have more info from Utrecht, Alex mentioned in the taiga issue that we can't see the tracing info in APM for the slow requests |
a7b47a6 to
ae8662f
Compare
|
@danielmursa-dev you can rebase on master to fix the failing image scanning job |
d16120e to
38a5221
Compare
38a5221 to
00ad87f
Compare
stevenbal
left a comment
There was a problem hiding this comment.
It does improve performance so I'll approve, but I don't think this solves the issue that's causing the outliers in the taiga issue, so I'll keep the github issue open for now. We'll have to hear back from Sander once he's done more tests (with the transaction rate in elastic APM set to 1, to make sure we have more trace info) or do tests ourselves to figure this out I think
Fixes #538
PyInstrumentMiddlewarefor profilinglocustexecutionget_querysetwithselect_relatedObjectUrlFieldtoCachedObjectUrlFieldGeometryField issue -> #538 (comment)
Results before improvements:
concurrent: https://github.com/maykinmedia/objects-api/actions/runs/15113315449/job/42477662337?pr=596#step:4:118single: https://github.com/maykinmedia/objects-api/actions/runs/15113315449/job/42477662337?pr=596#step:5:683Results after improvements:
concurrent: https://github.com/maykinmedia/objects-api/actions/runs/15113493879/job/42478246311?pr=596#step:4:118single: https://github.com/maykinmedia/objects-api/actions/runs/15113493879/job/42478246311?pr=596#step:5:683