Skip to content

Conversation

@stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented Jan 27, 2026

Closes #564 partially

Changes

  • Remove linkableToZaken field from objecttype mode
  • Ensure ObjectType._name is also set via import command

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.97%. Comparing base (ee2d14e) to head (aca1493).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   84.94%   84.97%   +0.02%     
==========================================
  Files         140      141       +1     
  Lines        2837     2842       +5     
  Branches      224      224              
==========================================
+ Hits         2410     2415       +5     
  Misses        375      375              
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🐰 Bencher Report

Branchissue/migration-command-remove-linkable-to-zaken
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
121.29 ms
(+0.53%)Baseline: 120.65 ms
126.69 ms
(95.74%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
22.36 ms
(+2.85%)Baseline: 21.74 ms
22.83 ms
(97.95%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
311.09 ms
(-10.62%)Baseline: 348.04 ms
365.44 ms
(85.13%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
316.15 ms
(+2.22%)Baseline: 309.30 ms
324.77 ms
(97.35%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
132.27 ms
(+0.86%)Baseline: 131.13 ms
137.69 ms
(96.06%)
🐰 View full continuous benchmarking report in Bencher

@stevenbal stevenbal marked this pull request as draft January 27, 2026 14:21
@stevenbal stevenbal force-pushed the issue/migration-command-remove-linkable-to-zaken branch from cba6b3e to aca1493 Compare January 27, 2026 14:38
@stevenbal stevenbal requested a review from Floris272 January 27, 2026 14:46
@stevenbal stevenbal marked this pull request as ready for review January 27, 2026 14:46
@stevenbal stevenbal mentioned this pull request Jan 27, 2026
16 tasks
Copy link
Contributor

@Floris272 Floris272 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevenbal stevenbal merged commit 7645cac into master Jan 28, 2026
26 of 27 checks passed
@stevenbal stevenbal deleted the issue/migration-command-remove-linkable-to-zaken branch January 28, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenObjecten - combine the ObjectsType API into the Objects API

3 participants