Skip to content

Handle importing optional libs in base config #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevenbal merged 4 commits into from
Jan 19, 2026
Merged

Handle importing optional libs in base config #199

stevenbal merged 4 commits into from
Jan 19, 2026

Conversation

@CharString
Copy link
Contributor

@CharString CharString commented Jan 13, 2026

Fixes #196

Changes

  • Handle import errors gracefully.
  • Warn when config is encountered for missing libraries
  • Prevent documenting config for uninstalled dependencies.

@CharString CharString linked an issue Jan 13, 2026 that may be closed by this pull request
Refactor OAF base.py to support optional libraries #196
Closed
@CharString CharString requested a review from stevenbal January 13, 2026 13:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.19626% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.54%. Comparing base (c08b80d) to head (2a964d0).

Files with missing lines Patch % Lines
open_api_framework/conf/utils.py 93.33% 2 Missing ⚠️
open_api_framework/conf/base.py 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   92.92%   93.54%   +0.62%     
==========================================
  Files          17       17              
  Lines         551      620      +69     
==========================================
+ Hits          512      580      +68     
- Misses         39       40       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stevenbal
stevenbal requested changes Jan 13, 2026
View reviewed changes
@CharString CharString force-pushed the 196-refactor-oaf-basepy-to-support-optional-libraries branch 6 times, most recently from a13d879 to 373e4cf Compare January 15, 2026 07:20
stevenbal
stevenbal requested changes Jan 15, 2026
View reviewed changes
@CharString
♻️ [#196] Handle * import from base config
56b2d76
@CharString
♻️ [#196] Fix annotation on get_django_project_dir
1a92c38 
And remove superfluous Path calls.
@CharString
💚 [#196] "Fix" LOGGING config for CI testapp
80c89a4 
Use default Django LOGGING and CACHES config in CI

testapp location is too different from default-project to make
base.BASE_DIR work correctly.

And CI doesn't spin up Redis instance.
@CharString
👷 [#196] Remove Django 4.2 from CI (pyproject and tox enfore >5.2
2a964d0 
179d8e7 seems to have overlooked this
@CharString CharString force-pushed the 196-refactor-oaf-basepy-to-support-optional-libraries branch from aacedfb to 2a964d0 Compare January 16, 2026 11:50
@CharString CharString requested a review from stevenbal January 16, 2026 11:57
@stevenbal stevenbal merged commit 0027ab0 into main Jan 19, 2026
7 checks passed
@stevenbal stevenbal deleted the 196-refactor-oaf-basepy-to-support-optional-libraries branch January 19, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenbal stevenbal stevenbal approved these changes

@danielmursa-dev danielmursa-dev Awaiting requested review from danielmursa-dev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor OAF base.py to support optional libraries

3 participants

@CharString @codecov-commenter @stevenbal