Merged
Conversation
BaseInfinity
force-pushed
the
assertions--add-ability-to-assert-in-natural-language
branch
from
e025fba to
be3126f
Compare
Contributor
Author
|
proof if it working =)
|
mayt
reviewed
Dec 15, 2023
Contributor
Author
|
Thanks for the CR! I'll most likely get to it later tonight or tomorrow morning =) |
Contributor
Author
|
Thanks for the CR, this is ready for review again |
mayt
reviewed
Dec 16, 2023
…lity-to-assert-in-natural-language
Contributor
Author
|
This is ready for more CR =) |
Fix merge conflict.
mayt
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a pull request open that outputs the generated code, I think what would make this useful in the testing space if it had the ability to assert things as well.
Let me know if this is starting to deviate too much from your original intentions.
I forked with intentions of making this an E2E testing tool for Playwright, whereas your intention seems to be more general purpose and you may not want all of my changes so feel free to reject changes that don't match eye to eye with your goals =)