Make stack-diff output prettier #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add more details to the README to show the user it's possible to make the stack-diff output more pretty * add the ability to use `icdiff` * correct a problem on macOS where the `type` command doesn't have a "-p" flag
mbailey
approved these changes
May 4, 2022
Owner
mbailey
left a comment
mbailey
left a comment
There was a problem hiding this comment.
Thanks Richard!
I don't like to change behaviour without a strong reason so will update to make it default to colordiff.
Perhaps replacing DIFF_CMD with BMA_DIFF_CMD would suit your needs (using icdiff when you also have colordiff installed)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the stack-diff function in a couple of simple ways.
typecommand doesn't have a "-p" flag. Therefor thestack-difffunction was always using planediffeven ifcolordiffwas installed and available.icdiffprogram, if available. This has the affect of making the diff output colored and side-by-side.more pretty. I wasn't sure where to put this so you might want to reformat it to make it fit the rest of the documentation better.