Replace hardcoded time tolerance values with 1e-10, which is about 0.1 second in 2026 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ESEC_REL_TOLERANCE class constant (1e-10) in combine.py for relative tolerance in time comparisons, providing ~0.1 second precision in 2026 - Replace hardcoded rtol=1e-10, atol=1e-6, and other time tolerance values with self.ESEC_REL_TOLERANCE for consistency - Update time_coverage_start/end metadata to use universals_depth_time as fallback when universals_time not available - Remove obsolete TIME_MATCH_TOLERANCE constant (replaced by ESEC_REL_TOLERANCE) - Fix align.py to not search for "universals_time" as a navigation coordinate in combined files (it's a time dimension, not a spatial coordinate) This appears to fix the "Inconsistent incorrect LRAUV processing to final _1S.nc file" Issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix the "Inconsistent incorrect LRAUV processing to final _1S.nc file" Issue: #115