-
Notifications
You must be signed in to change notification settings - Fork 26
EMAC memory manager improvements & fixes #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
connectivity/drivers/wifi/TARGET_STM/COMPONENT_EMW3080B/mx_wifi_mbed_os.cpp
Show resolved
Hide resolved
6b06a72 to
2cf8902
Compare
|
Actually... it appears that LPC1768 ethernet with LwIP is basically broken by this PR. I spent a good hour looking around but I wasn't able to find a smoking gun. I really don't see what exactly changed, but I think the EMAC driver was a bit shaky before (wasn't passing all the EMAC tests), and it has totally broken down now. Nanostack, somehow, does still work, but LwIP and the EMAC test suite seem to be unable to receive packets. I am planning to totally rewrite the LPC1768 EMAC driver in the near term anyway, so I think I'm going to table this one until I can do that rewrite. It just isn't worth wasting all this effort on a driver whose days are numbered anyway. On the bright side, I tested this branch with NUCLEO_F429ZI and K64F and all network tests passed there! |
78aa49e to
c1d4487
Compare
f04a0ff to
714eeb3
Compare
|
@JohnK1987 @JojoS62 Do you guys have a chance to look at this one? Gotta merge it first before the other Ethernet ones |
|
Will Check it today |
|
@JojoS62 Thanks to your discovery, all the LPC1768 issues are fixed! LPC1768 now passes all netsocket tests, except for emac, nanostack-udp, and nanostack-tcp (which seem to struggle with the low amount of memory). |

Summary of changes
This PR makes a number of fixes to the EMAC memory manager interface and to the three implementations of the manager (LWIP, Nanostack, and the EMAC test's mem manager). These are required for my upcoming STM32 EMAC MR.
Main changes are:
Impact of changes
Memory manager should have some new functions and be better documented.
Migration actions required
Documentation
Pull request type
Test results