-
Notifications
You must be signed in to change notification settings - Fork 27
Update of CMSIS and CMSIS-RTX to latest release and newlly as submodules #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
targets/TARGET_RENESAS/TARGET_RZ_A2XX/common/r_cache/inc/r_cache_l1_rza2m_asm.h
Outdated
Show resolved
Hide resolved
Refactor CMSIS path references in cmake file Message call for debug was removed
| ${CMAKE_CURRENT_LIST_DIR}/device/rtos/source/RTX/mbed_rtx_handlers.c | ||
| ${CMAKE_CURRENT_LIST_DIR}/device/rtos/source/RTX/mbed_rtx_idle.cpp | ||
| # Old CMSIS-RTOS v1 compatibility layer | ||
| ${CMAKE_CURRENT_LIST_DIR}/device/rtos/source/cmsis_os1.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... At some future date I'd like to investigate removing this, I am curious if there's anything in Mbed still using the OS 1 API calls, and if so, I'd like to update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is still using, it is not working without this.
I was thinking about create an issue about we have to remove all deprecated features/functions and also use/include everything only over CMSIS-RTOS2 API and not directly from RTX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's create an issue to remove use of the deprecated API. IIRC though, Mbed does require a few RTX features that aren't in the CMSIS RTOS API, so fixing that would be a much bigger project.
Summary of changes
The PR brings update of CMSIS 6 Core and RTX 5.9. This is now done using submodules, which will allow easy update in future because the implementation is done cleanly via CMake without modifying submodules.
RTX_config.h and rtx_def.h have to be overriden so their copies are placed outside of submodule and integrated back via CMake.
Like before it supports both profiles, bare‑metal and full RTOS, with shared RTOS2 API headers for both, and kernel sources are only linked for full profile.
Some parts were also prepared for future possibility to add FreeRTOS as alternative RTOS backend.
Impact of changes
Migration actions required
Proper testing on different targets. Because there were done some changes like
Documentation
The cmsis readme file was updated and simplified
Pull request type
Test results
I did GT test with Nucleo-H743ZI2 before and after implementation if these changes and results were same.
Reviewers