Linters: Small improvements + separate checks into different categories #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderpann
force-pushed
the
feature/linter_ui_and_separate_check_types
branch
from
e32ba81 to
38eb19a
Compare
alexanderpann
force-pushed
the
feature/linter_ui_and_separate_check_types
branch
from
38eb19a to
4a2d2e0
Compare
sergej-koscejev
approved these changes
Aug 29, 2024
Member
sergej-koscejev
left a comment
sergej-koscejev
left a comment
There was a problem hiding this comment.
I think the name forwardException is ambiguous, I expected the exception to be re-thrown but instead the construct formats it as a string, so formatException would have been a better name.
LGTM otherwise.
alexanderpann
force-pushed
the
feature/linter_ui_and_separate_check_types
branch
from
8ff45aa to
58b8e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for the next PR that will follow.
The UI was polished and there are now different kinds of checks: generic, module, model, root node and node checks which all have different parameters and return type. The old kind of check is the generic check:
Exceptions are now handled by default by the linter itself. You can still handle it yourself and/or forward the message to the results and the error log with the new
forwardExceptionexpression: