-
Notifications
You must be signed in to change notification settings - Fork 7
mpsqa.lint: add back missing location information to saved results #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpsqa.lint: add back missing location information to saved results #206
Conversation
a9239d0 to
d14ec37
Compare
|
if I do not have generated the linter, the result is an exception due to the "Result.location" being null java.lang.NullPointerException: Cannot invoke "Object.toString()" because the return value of "org.mpsqa.lint.generic.util.Result.location()" is null <<<<<<<<<<<<< In general, couldn't we use another default `value for location besides "null"? the code (many places in ResultEntry behavior) is quite heavily accessing resultLocation and might cause NPEs ... |
|
I only saw two potential cases where it could be null, so I just added two null checks. In ResultEntry, we need try catch blocks anyway, so NullPointers are not an issue there. |
…ure" - evaluation is not skipped and no whitelists are used (i.e. everything is GREEN)
|
looks good now - thank you! |

This is a follow-up of #184 where a forgot to adapt the saved messages and I also fixed a few linters where the error reporting was missing information. With this new change, you can also navigate in the checker results to files, nodes, models and modules. Files can now be returned as a result in linters.