fix: set explicit max-age in _set_coulomb_token to prevent cookie eviction#17
Merged
fix: set explicit max-age in _set_coulomb_token to prevent cookie eviction#17
Conversation
…ction aiohttp's CookieJar tracks expiry separately from the morsel value. Calling update_cookies() without max-age left the original 2-hour expiry timestamp intact, causing coulomb_sess to be evicted and triggering RuntimeError after 2 hours. Setting a ~10-year max-age overwrites the expiry timestamp on every refresh. Bumps version to 2.3.2. https://claude.ai/code/session_01DKeE6wx2BUUyNQnC6cJHZ8
Four new tests in test_client.py: - raises ValueError on empty token - cookie is retrievable immediately after being set - documents root cause: update_cookies() without max-age leaves prior expiry intact (aiohttp evicts after 1s in the test) - proves the fix: _set_coulomb_token overwrites the expiry so the cookie survives past the original server-set Max-Age https://claude.ai/code/session_01DKeE6wx2BUUyNQnC6cJHZ8
black 26.x removes the enforcement of two blank lines after the last import block. The system/CI environment was running black 26.1.0 while the lock file pinned 25.1.0, causing CI to flag __main__.py. Update the constraint and lock file to 26.3.1 (latest), and drop the spurious blank line to match the new rule. https://claude.ai/code/session_01DKeE6wx2BUUyNQnC6cJHZ8
client.py: - Extract _COULOMB_SESSION_MAX_AGE constant; drop magic number and comment tests/test_client.py: - Add _make_coulomb_cookie() helper to deduplicate SimpleCookie construction - Add _coulomb_expiry() helper to safely look up aiohttp's _expirations entry by cookie name rather than assuming domain/path normalisation - Replace asyncio.sleep(1.5) in two tests with direct _expirations inspection; test suite drops from ~3.7s to ~0.8s https://claude.ai/code/session_01DKeE6wx2BUUyNQnC6cJHZ8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiohttp's CookieJar tracks expiry separately from the morsel value.
Calling update_cookies() without max-age left the original 2-hour
expiry timestamp intact, causing coulomb_sess to be evicted and
triggering RuntimeError after 2 hours. Setting a ~10-year max-age
overwrites the expiry timestamp on every refresh.
Bumps version to 2.3.2.
https://claude.ai/code/session_01DKeE6wx2BUUyNQnC6cJHZ8