Update lib/format functions
#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now handles both expanded and unexpanded formatting codes.
Allowing the user to specify the name of the output variable makes for a better interface.
Makes it easier to add to programs under test without requiring that they source `lib/bats/helpers`.
Turns out Bash versions earlier than 4.1 can't use `printf -v` to print to a subscripted array variable.
Seems more natural to pass the items as positional parameters.
mbland
added a commit
that referenced
this pull request
Jan 15, 2017
Meant to say ASCII Unit Separator in #107, not Record Separator.
mbland
added a commit
that referenced
this pull request
Jan 15, 2017
After #107, in which I decided to use the ASCII Unit Separator ($'\x1f') to delimit array elements for `@go.array_printf` because doing so with NUL ($'\0') wasn't working, it seemed a good idea to switch the `_GO_CMD_NAME` and `_GO_CMD_ARGV` export mechanism to use the Unit Separator as well.
mbland
added a commit
that referenced
this pull request
Jan 15, 2017
The updates to `lib/format` from #107 make this function much shorter. Also, the logic to check the file descriptors was sort of confused and not really doing anything, at least not anything helpful, since the decision to print or strip formatting codes is now made per log level file descriptor in `@go.log`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the course of extracting and testing
tests/log/helpers.bashintolib/testing/log, I started updating@go.strip_formatting_codessuch that it will expand all codes the original string before stripping them.After that, I thought it would be nice to do away with the requirement that the caller declare predetermined
__go_*variables before using these functions, and switch to implementations that rely onprintf -vsuch that the caller can pass in the name of the variable it will use to store the result. Hence I imported thelib/validationmodule to validate the result variable name for each function.Then I learned after observing test failures under Bash 3.2.57(1)-release that Bash versions before 4.1 can't use
printf -vto assign to subscripted array variables. I developed the new@go.array_printffunction as a portable workaround, which relies on@go.splitfromlib/stringsunder the hood.