path: Search _GO_SCRIPTS_DIR before plugin dirs
#128
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #120, and similar to #122, searching the local `_GO_SCRIPT_DIR` before plugin dirs seems like a more natural and scalable model. `_GO_CORE_DIR/libexec` for builtins still comes first. The idea behind this model is that when reading a script within the `./go` script framework, it should be clear that: - core framework scripts are the same everywhere; they can't be shadowed by scripts with the same name - project-local scripts take precedence before any plugin scripts The implications of this last point are that: - a script that is installed as a plugin will find its own scripts before those that share the same name with other installed plugins, avoiding collisions and possibly obscure bugs - the parent project can determine the precedence of plugin scripts sharing the same name, as the plugins can be installed using directory names that force a particular order (e.g. '00-', '01-', '02-' prefixes). - as an alternative to the approach in the preceding point, the parent project can potentially resolve conflicts by installing its own scripts that then delegate to a specific plugin script And to this last point, I've filed #127 to facilitate help text discovery.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #120, and similar to #122, searching the local
_GO_SCRIPT_DIRbefore plugin dirs seems like a more natural and scalable model._GO_CORE_DIR/libexecfor builtins still comes first.The idea behind this model is that when reading a script within the
./goscript framework, it should be clear that:The implications of this last point are that:
And to this last point, I've filed #127 to facilitate help text discovery.