Implement correct scope for executing @go commands in plugin modules
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates a slight amount of complexity from both `@go.search_plugins`, `lib/internal/path`, and `lib/internal/use`.
This is part of the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules.
This is part of the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules. This also eliminates the need for `_@go.set_use_caller`.
This is part of the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules.
This is part of the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules.
This is part of the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules. Specifically, it allows the `@go plugins` builtin command to produce the proper output relative to each plugin, but more generally, it makes sense to strip a plugin's `_GO_SCRIPTS_DIR` out of its `_GO_PLUGINS_PATHS`, rather than just stripping it from `_GO_SEARCH_PATHS`.
This is part of the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules. Specifically, this makes sure that the module search paths are set correctly independent of the `@go` function being called. This is to ensure that modules behave as expected when imported before the top-level `./go` script calls `@go`.
This concludes the refactoring of `_GO_USE_MODULES` to provide correct `@go` command script scope for plugin modules. It is germane to #120. Whereas #136 implemented correctly-scoped lookup of other plugin modules, this allows any module, plugin or otherwise, to invoke its own command scripts or plugin command scripts via `@go`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
_GO_USE_MODULESto provide correct@gocommand script scope for plugin modules. It is germane to #120.Whereas #136 implemented correctly-scoped lookup of other plugin modules, this allows any module, plugin or otherwise, to invoke its own command scripts or plugin command scripts via
@go.This PR contains lots of granular commits that contain individual refactoring steps building up to the final one that implements correct
@gocommand scope. The last commit is the only one that introduces fundamentally new behavior.