Skip to content

Add go-template for bootstrapping ./go scripts #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbland merged 5 commits into from
Feb 11, 2017
Merged

Add go-template for bootstrapping ./go scripts #155

mbland merged 5 commits into from
Feb 11, 2017

Conversation

@mbland
Copy link
Owner

@mbland mbland commented Feb 10, 2017

Closes #144.

@mbland mbland added this to the v1.4.0 milestone Feb 10, 2017
@mbland mbland self-assigned this Feb 10, 2017
@mbland
template: Don't send git clone output to /dev/null
a454f98 
Previously I'd squelched the output because of the verbosity of the
`detached HEAD` warning when making a shallow clone, but it's not really
necessary anymore given `-c advice.detachedHead=false`. Now that the
`template` test is failing on Travis, I really need to see the output:

https://travis-ci.org/mbland/go-script-bash/jobs/200472791
https://travis-ci.org/mbland/go-script-bash/jobs/200472885
@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage remained the same at 95.285% when pulling 0767f7f on template into 5dd8651 on master.

@mbland
template: Fix Windows/MSYS2 test failure
1cb75cd 
On MSYS2, `/tmp` (used in `TEST_GO_ROOTDIR` via `BATS_TMPDIR`) is mapped
to `C:/Users/<user>/AppData/Local/Temp/`. When `git clone ... ` is called
with a path starting with `/tmp`, its output show the `C:/Users/...`
path instead.

The fix is to update the `assert_output_matches` expression to match
only the `scripts/go-script-bash` suffix of the clone path instead of
the entire path.
@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage remained the same at 95.285% when pulling a454f98 on template into 5dd8651 on master.

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage remained the same at 95.285% when pulling 303485e on template into 5dd8651 on master.

@coveralls
Copy link

coveralls commented Feb 11, 2017

Coverage Status

Coverage remained the same at 95.285% when pulling 1f23ffb on template into 5dd8651 on master.

@mbland mbland merged commit abe6a54 into master Feb 11, 2017
@mbland mbland deleted the template branch February 11, 2017 00:13
mbland added a commit that referenced this pull request Feb 12, 2017
@mbland
test: Add go-coverage to coverage includes
1c15947 
Should've been part of #155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mbland mbland

Labels

enhancement

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mbland @coveralls