hotfix(Cache.KeyGenerator): don't hash single binaries #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
approved these changes
Apr 7, 2025
Contributor
anthonyshull
left a comment
anthonyshull
left a comment
There was a problem hiding this comment.
We could also think about using a stronger hash in the future:
> :crypto.hash(:sha3_512, "10590") |> Base.encode16()
"EA5504962775343FC4A835AEB4C19FA2D99AF9ECE1107740EFCAFA79169780FF221F8AC7DD0D08450954CE0E94B823AE0B2B8C1BD1AB6D315A4D7EA0A3A994BF"
> :crypto.hash(:sha3_512, "2783") |> Base.encode16()
"11FFE740A2720960975F271FF01FE42B617884EFF1BF1059C596A45F9766952D15CE9AEEB497A1645F2FB00A18D7B0BC6CFAC4383ABB1261E259AE2F15B158CB"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor note: this changes handling of a single argument which isn't a binary - instead of hashing it directly it'll be wrapped in a list (e.g.
:erlang.phash2([arg])instead of:erlang.phash2(arg))But I also took the suggestion to increase the range via the second argument of
:erlang.phash2/2