fix(ScheduleFinderLive): end of service for today #2894
Merged
+71
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh Larson <jlarson@mbta.com>
# Conflicts: # lib/dotcom/schedule_finder/upcoming_departures.ex # lib/dotcom_web/live/schedule_finder_live.ex
joshlarson
approved these changes
Jan 21, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
Left two stylistic comments, but this looks good either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] 🐞 Fix subway "service continues until" so it's not connected to the service picker
Implementation
Had to find another way to get that end of service time. I decided to partially reuse the logic for getting predicted schedules. This way, if the last trip happens to be a delayed prediction, the display can reflect this (instead of showing an outdated schedule value).
How to test
Go to any subway line, notice the "Service Continues Until" time no longer changes when you change the service picker selection.
No screenshots included because this should be a no-op, and the "Service Continues Until" time should continue to match the latest "Last train" time from the Daily Schedules section (for current/today service).