Conversation
Added function to determine if a match date is valid Started the selected match banner
joshlarson
approved these changes
Feb 20, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
Nice! I had originally had a different vision for how <.match_link /> and <.selected_match_banner /> would interplay, but honestly, I think your approach works better than what I had in mind 🥳
I left a bunch of LiveView style comments, and honestly a bunch of them are ones that I'll probably want to implement either as part of this PR or as follow-up work that we do pretty soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: Specific match - fancy label with selected match (design TBD)
Implementation
Created selected_match_banner function/component
Added some logic to hide/show UI elements depending on if a match is selected
Screenshots
Design
Implementation
How to test
http://localhost:4001/preview/schedules/CR-WorldCup Then select a match!