Skip to content

hotfix: Don't de-dup special snow service schedules#2967

Merged
joshlarson merged 1 commit intomainfrom
jdl/hotfix/dont-dedup-special-snow-service-schedule
Feb 24, 2026
Merged

hotfix: Don't de-dup special snow service schedules#2967
joshlarson merged 1 commit intomainfrom
jdl/hotfix/dont-dedup-special-snow-service-schedule

Conversation

@joshlarson
Copy link
Contributor

Scope

Asana Ticket: Snow Service not showing up in the daily schedule service picker (incorrect schedules are showing for today)

Implementation

  • A combo of the current set of service deduplication heuristics and the fact that the special snow service is called Fall/WinterWeekday and has no indication that it's unusual (aside from the fact that its typicality is :planned_disruption, but all CR services appear to be :planned_disruption right now), caused the special snow service to get collapsed into regular weekday service.
  • Off the top of my head, I couldn't think of a good heuristic that would split this service out from other weekday services, so I just special-cased the start date of the current snow service schedule disruption.

Screenshots

Before

Screenshot 2026-02-24 at 8 28 45 AM

After

Screenshot 2026-02-24 at 8 28 17 AM

Notice that there's now an entry for Feb 22 - Feb 24, and also that the trips that show are different. 👇 is a screenshot of the timetable for today, which shows that the trips in the After screenshot are correct.

Screenshot 2026-02-24 at 8 29 52 AM

How to test

Go to schedule finder for Providence and see that there is an entry for the special snow schedules in the service-picker dropdown menu.

@joshlarson joshlarson requested a review from a team as a code owner February 24, 2026 13:39
@joshlarson joshlarson requested a review from lvachon1 February 24, 2026 13:39
@joshlarson joshlarson enabled auto-merge (squash) February 24, 2026 13:42
@joshlarson joshlarson merged commit f1c55cb into main Feb 24, 2026
26 checks passed
@joshlarson joshlarson deleted the jdl/hotfix/dont-dedup-special-snow-service-schedule branch February 24, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants