Fix container issue on live page before it goes live live#2998
Merged
Fix container issue on live page before it goes live live#2998
Conversation
…ontainer wrapper, child pages will supply their own now. Removed now redundant param that disabled the container.
joshlarson
requested changes
Mar 6, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
I think the scope here needs to be a bit wider - this PR will fix the container issue for live views that are still in preview, but not for live views that are out of preview mode and use the regular live layout, which also indiscriminately wraps its inner block in a container.
The solution that I'm thinking is...:
- Update the
livelayout so that it no longer wraps its contents in<div class="container">...</div>.- (Possibly at this point, we just delete the
livelayout, because it's not doing anything. In theory, we could keep it, in case we ever decide that we need or want a shared live view layout that's separate from non-live-view pages, but that seems pretty unlikely to me)
- (Possibly at this point, we just delete the
- Update the live views that currently use the
livelayout to wrap themselves in their own<div class="container">...</div>.- Commuter Rail and Subway alerts/status pages.
Schedule FinderDepartures Page- Search page
- Trip Planner
- Stop Map (Optional - this page is a lo-fi proof-of-concept, but it does look pretty silly stretched all the way across the screen!)
joshlarson
approved these changes
Mar 10, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
On further reflection, I think the changes I requested could very easily be done in a separate PR.
I'm not opposed to putting those changes into this PR, but also not opposed to doing them as a follow-up.
Contributor
Author
|
I removed the container from other pages before I saw your comment, Josh. I'm requesting a re-review just to make sure I haven't done anything stupid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ⚽️ Fix container issue on live page before it goes live live
Implementation
Stopped the preview page from assuming it's children pages wanted a container wrapper, child pages will supply their own now. Removed now redundant param that disabled the container.
Screenshots
How to test
http://localhost:4001/preview/ - Everything looks the same