Skip to content

feat(TimetableController): CSV-based Foxboro trips#3001

Merged
thecristen merged 2 commits intomainfrom
cbj/wc/friendly-data
Mar 9, 2026
Merged

feat(TimetableController): CSV-based Foxboro trips#3001
thecristen merged 2 commits intomainfrom
cbj/wc/friendly-data

Conversation

@thecristen
Copy link
Collaborator

Scope

In preparation for tickets going on sale to the friendly game on 3/26!

Implementation

We're partially re-using the hack that lets us show custom timetables for the Boat-F6/7/8 routes, with slightly more hack layered on top for the one day we won't have GTFS data for. It is neither the best nor worst code I've written.

  • Dotcom.Timetableloader got an extra customization to add a trip name, so that we can show train names in the table
  • DotcomWeb.ScheduleController.TimetableController got an extra clause in assign_trip_schedules/1. The existing clause for handling the Dotcom.Timetableloader-based data wasn't quite adequate as-is, since there were a few differences between how the ferry-based timetables and how this Foxboro timetables wished to handle absent data.

Screenshots

image

How to test

@thecristen thecristen requested a review from a team as a code owner March 9, 2026 15:59
@thecristen thecristen requested review from joshlarson and lvachon1 and removed request for lvachon1 March 9, 2026 15:59
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quickly!

@thecristen thecristen merged commit 053acd3 into main Mar 9, 2026
25 checks passed
@thecristen thecristen deleted the cbj/wc/friendly-data branch March 9, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-blue Deploy to dev-blue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants