feat(TimetableController): CSV-based Foxboro trips#3001
Merged
thecristen merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
joshlarson
approved these changes
Mar 9, 2026
Contributor
joshlarson
left a comment
There was a problem hiding this comment.
Thanks for doing this so quickly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
In preparation for tickets going on sale to the friendly game on 3/26!
Implementation
We're partially re-using the hack that lets us show custom timetables for the Boat-F6/7/8 routes, with slightly more hack layered on top for the one day we won't have GTFS data for. It is neither the best nor worst code I've written.
Dotcom.Timetableloadergot an extra customization to add a trip name, so that we can show train names in the tableDotcomWeb.ScheduleController.TimetableControllergot an extra clause inassign_trip_schedules/1. The existing clause for handling theDotcom.Timetableloader-based data wasn't quite adequate as-is, since there were a few differences between how the ferry-based timetables and how this Foxboro timetables wished to handle absent data.Screenshots
How to test