Skip to content

Old Schedule Finder links redirect to SF 2.0 #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvachon1 merged 8 commits into from
Apr 8, 2026
Merged

Old Schedule Finder links redirect to SF 2.0 #3012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71f3e05
Added a rewrite function to detect schedule finder URLs and send them…
lvachon1 Mar 12, 2026
b4d2073
Lint
lvachon1 Mar 12, 2026
09280f3
More lint
lvachon1 Mar 12, 2026
3ddd0d7
I was too stuck in javascript mindset and using the wrong syntax for …
lvachon1 Mar 16, 2026
fc4558b
Fixed bug in query concatination code, alphebitzed param order, wrote…
lvachon1 Mar 16, 2026
3d4db49
Fixed redirect logic for "Green" line special case, cleaned up a bit …
lvachon1 Mar 18, 2026
013df31
Merge branch 'main' into lev/feat/sf/redirect_sf1
lvachon1 Mar 18, 2026
6045b91
Merge branch 'main' into lev/feat/sf/redirect_sf1
lvachon1 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion lib/dotcom_web/plugs/rewrite_urls.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,27 @@ defmodule DotcomWeb.Plugs.RewriteUrls do
end
end

# Send SF1.0 URLS to the new SF2.0
defp rewrite_url(%{
path_info: ["schedules", _, "line"],
params: %{
"route" => route_id,
"schedule_finder" => %{"direction_id" => direction_id, "origin" => stop_id}
}
}) do
"/departures/?route_id=#{route_id}&direction_id=#{direction_id}&stop_id=#{stop_id}"
end

# "Green" line special case
defp rewrite_url(%{
path_info: ["schedules", "Green", "line"],
params: %{
"schedule_finder" => %{"direction_id" => direction_id, "origin" => stop_id}
}
}) do
"/departures/?route_id=Green&direction_id=#{direction_id}&stop_id=#{stop_id}"
end

defp rewrite_url(%{path_info: ["schedules", "Boat-F3" | _]} = conn) do
String.replace(conn.request_path, "Boat-F3", "Boat-F1")
end
Expand All @@ -38,6 +59,10 @@ defmodule DotcomWeb.Plugs.RewriteUrls do
end

defp merge_url(base_url, query_string) do
"#{base_url}?#{query_string}"
if base_url |> String.contains?("?") do
"#{base_url}&#{query_string}"
else
"#{base_url}?#{query_string}"
end
end
end
22 changes: 22 additions & 0 deletions test/dotcom_web/plugs/rewrite_urls_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,28 @@ defmodule DotcomWeb.Plugs.RewriteUrlsTest do
assert conn.halted
end

test "redirects if we're going to the old schedule finder", %{conn: conn} do
route_id = Faker.Pokemon.name()
direction_id = Faker.Util.pick(["0", "1"])
stop_id = Faker.Pokemon.name()

conn = %{
conn
| params: %{
"route" => route_id,
"schedule_finder" => %{"direction_id" => direction_id, "origin" => stop_id}
},
path_info: ["schedules", "red", "line"]
}

conn = call(conn, [])

assert redirected_to(conn, 302) ==
"/departures/?route_id=#{route_id}&direction_id=#{direction_id}&stop_id=#{stop_id}"

assert conn.halted
end

test "includes a query string if present", %{conn: conn} do
conn = %{
conn
Expand Down
Loading