feat(SF2.0): Update marker for skipped stops in expanded trip details#3046
Merged
joshlarson merged 3 commits intomainfrom Mar 27, 2026
Merged
feat(SF2.0): Update marker for skipped stops in expanded trip details#3046joshlarson merged 3 commits intomainfrom
joshlarson merged 3 commits intomainfrom
Conversation
Contributor
It appears we have a white border of some kind that doesn't play well with the grey background.
Fun fact: I used to take this bus to/from middle school! |
Contributor
Author
|
@lvachon1 Thanks for catching that!
|
Contributor
Author
|
OH! It's not Trying to think of an elegant solution here.... |
Contributor
Author
|
I had to change the background color to a regular color, rather than relying on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Update skipped stop marker
Implementation
fill="currentColor"in an SVG to cause a path to get filled with the current text color instead of the current fill color!Screenshots
Check out how nicely it respects the foreground and background colors!
How to test
Create a fake stop closure in Alerts Manager Staging and then visit departures page a departure page for another stop on the same route. (Right now, Main St @ Copeland St has a fake stop closure, so you can take a look at Main St @ Gilbert St - expand any of the trip details, and enjoy the new marker!)
Notes
There is a known bug where sometimes skipped stops don't appear in the expanded trip details at all. I think that happens when the scheduled time for that stop drifts into the past (there's a separate ticket to address that), or when the trip in question is added, and doesn't include a prediction at that stop (I'm honestly not sure if we can address that).