Skip to content

feat(SF2.0): Add The Squiggle for collapsed trip details#3059

Merged
joshlarson merged 5 commits intomainfrom
jdl/sf2.0/the-squiggle
Apr 8, 2026
Merged

feat(SF2.0): Add The Squiggle for collapsed trip details#3059
joshlarson merged 5 commits intomainfrom
jdl/sf2.0/the-squiggle

Conversation

@joshlarson
Copy link
Copy Markdown
Contributor

@joshlarson joshlarson commented Mar 27, 2026

Scope

Asana Ticket: 📅🔎〰️ Draw the squiggle

Implementation

  • Hand-rolled SVG's - I finally got to put my (very basic) understanding of Bézíer Curves to work!
  • Fully replace the lined_list_item depending on whether the "more trips" section (this also resolves a kind of annoying visual bug where "Show fewer stops" wasn't aligned exactly the same as "Show more stops", so the text looked like it jumped around a little bit.
  • 🤖 As part of an experiment, I've occasionally been using Copilot to do some tasks. The second commit in this PR was partially written with the help of Claude Code.

Screenshots

Screenshot 2026-03-27 at 5 05 12 PM

How to test

Go to any departures page and see how The Squiggle is there (when there are "more stops" to show), and disappears when "more stops" is expanded.

Notes

Looking at the page zoomed in and expanding "more stops" shows off the fact that the borders for expanded stops appear to be on top of the line diagram, as in the screenshot below. That's an existing issue, unrelated to the work in this PR, and is captured in a different ticket.

Screenshot 2026-03-27 at 5 10 32 PM

(This screenshot was taken in prod)


Blocked by:

Update: No longer blocked by work in mbta_metro.

@joshlarson joshlarson marked this pull request as ready for review April 7, 2026 19:41
@joshlarson joshlarson requested a review from a team as a code owner April 7, 2026 19:41
@joshlarson joshlarson requested a review from jlucytan April 7, 2026 19:41
@joshlarson joshlarson enabled auto-merge (squash) April 7, 2026 19:45
@lvachon1
Copy link
Copy Markdown
Contributor

lvachon1 commented Apr 8, 2026

Screenshot 2026-04-08 at 9 51 26 AM

Everything seems to look great except for the busses? It seems stroke-brand-bus is not doing anything?

@joshlarson
Copy link
Copy Markdown
Contributor Author

@lvachon1 Great catch - thank you!

Fixed here, I think

Copy link
Copy Markdown
Contributor

@lvachon1 lvachon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Lookin good!

@joshlarson joshlarson merged commit 7d389c1 into main Apr 8, 2026
17 checks passed
@joshlarson joshlarson deleted the jdl/sf2.0/the-squiggle branch April 8, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants