tests(SF2.0): Extract shared journey abstraction for UpcomingDeparturesTest#3074
Merged
joshlarson merged 53 commits intomainfrom Apr 7, 2026
Merged
tests(SF2.0): Extract shared journey abstraction for UpcomingDeparturesTest#3074joshlarson merged 53 commits intomainfrom
UpcomingDeparturesTest#3074joshlarson merged 53 commits intomainfrom
Conversation
…r_on_day` instead of `later_on_day`
joshlarson
changed the title
UpcomingDepar… c8210cc …turesTest
joshlarson
changed the title
UpcomingDepar… c8210cc …turesTestUpcomingDeparturesTest
…iff pretty gnarly, but the only actual change is re-ordering some tests)
…and departure_time *does* matter!)
thecristen
requested changes
Apr 4, 2026
Collaborator
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
Overall, this is a great step forward for these tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This PR exists because while trying to fix a (relatively minor) bug, I accidentally introduced a few more, which none of the tests caught. The tests have become difficult enough to work with that I couldn't even figure out a way to validate the behavior that I broke without introducing potentially hundreds of additional lines of test code.
Asana Ticket: [SF2.0/TechDebt] Clean up UpcomingDeparturesTest
Implementation
UpcomingDeparturesTestmodule (and maybeTripDetailsTest, although maybe that cleanup should get punted to a different PR) by taking all of the shared inherent complexity of creating matching schedules and predictions, and shoving that complexity into aPredictedScheduleHelpermodule.