SF2.0[fix]: Improve funky focus outline, fix gap#3077
Merged
Conversation
… info section if additional info was an empty list. Adjusted lined list item CSS to overlap the line a little bit less so that the focus outline isn't as wonky. Unfortunately, getting rid of the focus outline wonk entirely brings back the little gap issue.
lvachon1
commented
Apr 2, 2026
joshlarson
reviewed
Apr 3, 2026
joshlarson
reviewed
Apr 3, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
A few thoughts on px versus rem, and some historical context for my initial (probably not very good) attempt to align things!
…t reintroducing the gap
joshlarson
approved these changes
Apr 7, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
This actually fixes the gap issue and doesn't fix the funky focus outline, so it's probably worth updating the PR description.
But it does fix the gap issue (at least for all font sizes I tested), so IMO it's worth getting out there!
lvachon1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Fix funky focus outline
Implementation
Adjusted schedule finder logic so it wouldn't render an empty additional_info section if additional_info was an empty list.
Adjusted lined_list_item CSS to overlap the line a little bit less so that the focus outline isn't as wonky. Unfortunately, getting rid of the focus outline wonk entirely brings back the little gap issue.
Screenshots
🚇 Subway
🚂 Commuter Rail
🚌 Bus
How to test
http://localhost:4001/departures/?route_id=71&direction_id=1&stop_id=2052
Check out various lines and modes and observe that the focus outlines look much better than before.