fix: use rewrite_url/1 for teaser images#3088
Merged
thecristen merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
lvachon1
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
In this Slack thread it was shared that the first image in the right rail on the World Cup Guide page directly points to our Drupal URL, which we generally avoid doing around here.
Implementation
We usually rewrite content URLs to avoid that, but there was a spot we missed. Each content type seems to be handled in its own way so this took a while to track down. But this was a teaser of a page rendered within a
ContentList.edit in second commit: should apply to any image parsed from a Teaser.
How to test
Go to http://localhost:4001/guides/world-cup-guide (or deploy it and go to that path there) and see the
srcof the image is a relative URL rather than an absolute URL topantheon.io. Another example is the related project at/projects/green-line-c-branch-station-accessibility-improvements.