chore: remove DotcomWeb.Components.Prototype#3096
Merged
thecristen merged 3 commits intomainfrom Apr 9, 2026
Merged
Conversation
We no longer need that callback since we're not switching routes/stops within this LiveView.
joshlarson
approved these changes
Apr 9, 2026
Contributor
joshlarson
left a comment
There was a problem hiding this comment.
Goodbye Prototype Picker! It was a good run 🥲
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎🚀 | QF | Pre-release, remove the testing route/direction/stop selector from the top
Implementation
Removed the component, then realized we don't need the
handle_params/3callback, as that's useful when navigating within a LiveView.mount/3. So I did this refactor, which let me remove some of the smaller intermediate functions likeassign_route/2orassign_stop/2.mount/3as well. Turns out you can raise an exception.:if={@stop}from the template, since by the time we render we've already fetched the stop.The diff looks more dramatic than it actually is, because nothing else was changed here...
Screenshots
It looks the same, but without the buttons for switching any of the URL params.
How to test
Manually try different URLs 😩
route_id,direction_idorstop_idwill return the 404 page