Trip Planner [Fix]: Out of system transfer logic#3205
Merged
Conversation
…ansfers to ensure those transfers happen in the same (or connected) stations. This is to handle the cases where OTP suggests walking between stations, but incorrectly counted that as a valid transfer.
…ic from the single_ride_trip transfer function and to allow the (formerly unused) subway_transfer?() code to handle it.
…eg handler for subway transfers. Removed redundant lower level tests.
joshlarson
approved these changes
May 29, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
Approving because this does fix a class of bugs, but this still leaves out-standing the issue below:
The fare for this should be $4.80, not $3.10.
If you want to merge as-is, I can create a follow-up ticket for this case :)
Contributor
Author
|
Yeah, I feel tacking the fare bugs in small pieces is probably the best way forward. There's a lot of logic in there, and a lot of exceptions and edge cases. I'm wary of making more than one change at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐞 Trip Planner | Fix out of system transfer logic
Implementation
Removed subway -> subway transfers from the maybe_transfer?()/@single_ride_transfer logic, as this needs to know the stations involved to properly calculate transfers. Re-added the formerly unused subway_transfer?() logic that did this already.
This is to handle the cases where OTP suggests walking between stations, but the fare was incorrectly calculated as if that was an in-fare transfer.
Screenshots
Branch
Dev
How to test
http://localhost:4001/trip-planner?plan=hsQVX3VudXNlZF9kYXRldGltZV90eXBlxADEEl91bnVzZWRfd2hlZWxjaGFpcsQAxAhkYXRldGltZcQgMjAyNi0wNS0yMlQxMjo1MDo0Ny4xMzQ4NTItMDQ6MDDEBGZyb22ExAhsYXRpdHVkZctARS_O2RaHK8QJbG9uZ2l0dWRly8BRx5y2hIvrxARuYW1lxDlIYXJ2YXJkIFNxdWFyZSwgQnJhdHRsZSBTdHJlZXQsIENhbWJyaWRnZSwgTUEsIDAyMTM4LCBVU0HEB3N0b3BfaWTEAMQFbW9kZXOJxANCVVPEBHRydWXEBUZFUlJZxAR0cnVlxARSQUlMxAR0cnVlxAZTVUJXQVnEBHRydWXEDl9wZXJzaXN0ZW50X2lkxAEwxAtfdW51c2VkX0JVU8QAxA1fdW51c2VkX0ZFUlJZxADEDF91bnVzZWRfUkFJTMQAxA5fdW51c2VkX1NVQldBWcQAxAJ0b4TECGxhdGl0dWRly0BFMxYJVsDXxAlsb25naXR1ZGXLwFG_nYg7o0TEBG5hbWXES1dvbmRlcmxhbmQgR3JleWhvdW5kIFBhcmssIDE5MCBSZXZlcmUgQmVhY2ggUGFya3dheSwgUmV2ZXJlLCBNQSwgMDIxNTEsIFVTQcQHc3RvcF9pZMQA
Any other route that involves a red to blue transfer should work.
Confirm that leaving one station and entering another on foot is included in the fare calculation.
Confirm that transfers within the fare gates are still free.