fix(Dotcom.ServicePatterns): extra_service date handling#3223
Merged
Conversation
It turns out extra_service doesn't use added_dates to describe its single date of service.
joshlarson
approved these changes
Jun 1, 2026
Co-authored-by: Josh Larson <jlarson@mbta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Slack thread - came up while testing the upcoming rating and noticing Jun 13 not being clear
Implementation
It turns out services using the
:extra_servicetypicality might not useadded_datesto describe its single date of service, but we were relying on parsing that to show special dates.Screenshots
Before - extended event service without date (or missing entirely)
After - extended event service now annotated with Jun 13
How to test
Using dev-blue data, you can visit schedule finders for most routes using this service on June 13.