fix(android.localization): Use older language tag scheme#1645
Merged
KaylaBrady merged 2 commits intomainfrom Apr 7, 2026
Merged
fix(android.localization): Use older language tag scheme#1645KaylaBrady merged 2 commits intomainfrom
KaylaBrady merged 2 commits intomainfrom
Conversation
KaylaBrady
commented
Apr 7, 2026
| ) | ||
|
|
||
| val content = NotificationContent.build(applicationContext.resources, payload) | ||
| // The applicationContext is not always guaranteed to be set to use the current system |
Collaborator
Author
There was a problem hiding this comment.
TY @EmmaSimon for this diff!
Tested it out with english & french as my primary language and confirmed the notification was in the correct language.
EmmaSimon
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Notifications QA | Notifications sent in lower-tier language
What is this PR for?
This PR doesn't actually address the named issue; it seems like that is an OS-level bug (ex: this pixel support thread, which claims the issue was fixed March 2025).This does address the named issue, thanks to Emma's fix!This addresses the issue @EmmaSimon raised in slack about languages with region codes not localizing at all.
iOS
android
withContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?