Merged
Conversation
Keep showing the direction toggle if it was visible when you first opened the add favorite page, even if the direction that you toggle to was already a saved favorite. When a saved favorite is opened directly then the toggle is never shown.
boringcactus
approved these changes
Apr 9, 2026
| var wasAdding by rememberSaveable { mutableStateOf(favorites != null && !isFavorite) } | ||
| val showDirectionToggle by | ||
| rememberSaveable(stopDirections, wasAdding) { | ||
| mutableStateOf(stopDirections.size > 1 && wasAdding) |
Member
There was a problem hiding this comment.
If this is just a val it probably doesn’t need to be a mutableStateOf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Notifications QA | Edit favorite direction toggle
Keep showing the direction toggle if it was visible when you first opened the add favorite page, even if the direction that you toggle to was already a saved favorite. When a saved favorite is opened directly then the toggle is never shown.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Added unit tests confirming the new behavior, tested manually