fix(ios.NotificationsSettingsWidget): Prevent 0 minute window#1651
Merged
KaylaBrady merged 3 commits intomainfrom Apr 10, 2026
Merged
fix(ios.NotificationsSettingsWidget): Prevent 0 minute window#1651KaylaBrady merged 3 commits intomainfrom
KaylaBrady merged 3 commits intomainfrom
Conversation
KaylaBrady
commented
Apr 8, 2026
| ) | ||
| } | ||
|
|
||
| func setSafeEndTime(startTime: DateComponents) { |
Collaborator
Author
There was a problem hiding this comment.
I don't love this approach, but breaking out a separate fun seemed like the easiest way to add testing.
What I don't love is that it takes a startTime as a param, even though window has its own startTime.
Maybe there is something to be done with didSet instead of the .onChange(of: window.startTime) { startTime in call from NotificationSettingsWidget ... but we aren't really doing that elsewhere
BrandonTR
reviewed
Apr 9, 2026
Contributor
BrandonTR
left a comment
BrandonTR
left a comment
There was a problem hiding this comment.
Overall looks good! Couple of minor things
…in 59 and is after end time
BrandonTR
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Notifications QA | iOS - Ensure windows are at least 1 minute long
What is this PR for?
Ensures that start time can't be changed to match end time, and end time can't be changed to match start time.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?