Skip to content

feat(MorePage.SendAppFeedback): Collect user settings#1652

Merged
KaylaBrady merged 2 commits intomainfrom
kb-collect-settings
Apr 9, 2026
Merged

feat(MorePage.SendAppFeedback): Collect user settings#1652
KaylaBrady merged 2 commits intomainfrom
kb-collect-settings

Conversation

@KaylaBrady
Copy link
Copy Markdown
Collaborator

Summary

Ticket: Collect settings with feedback form submission

What is this PR for?

  • Records user settings as feedback form url params to add context for understanding feedback

iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
- [ ] Add temporary machine translations, marked "Needs Review"

android
- [ ] All user-facing strings added to strings resource in alphabetical order
- [ ] Expensive calculations are run in withContext(Dispatchers.Default) where possible (ideally in shared code)

Testing

What testing have you done?

  • Added unit tests
  • Ran locally on iOS & android, confirmed in Splunk logs that I see the expected params
image image

@KaylaBrady KaylaBrady requested a review from a team as a code owner April 9, 2026 14:36
@KaylaBrady KaylaBrady requested a review from boringcactus April 9, 2026 14:36
@KaylaBrady KaylaBrady added this pull request to the merge queue Apr 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 9, 2026
@KaylaBrady KaylaBrady added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit ba27e41 Apr 9, 2026
11 checks passed
@KaylaBrady KaylaBrady deleted the kb-collect-settings branch April 9, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants