Skip to content

fix(Android): use fixed pill in FavoriteStopCard#1661

Merged
boringcactus merged 1 commit intomainfrom
mth-tvpxrvztxrzr
Apr 13, 2026
Merged

fix(Android): use fixed pill in FavoriteStopCard#1661
boringcactus merged 1 commit intomainfrom
mth-tvpxrvztxrzr

Conversation

@boringcactus
Copy link
Copy Markdown
Member

Summary

Ticket: Notifications QA | CR route pills in add favorites flow

Conveniently, we’re already doing the right thing on iOS.

Before After
Screenshot_20260410_162954 Screenshot_20260410_163037

iOS

  • [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • [ ] Add temporary machine translations, marked "Needs Review"

android

  • [ ] All user-facing strings added to strings resource in alphabetical order
  • [ ] Expensive calculations are run in withContext(Dispatchers.Default) where possible (ideally in shared code)

Testing

Added a unit test and manually checked that behavior is now correct.

@boringcactus boringcactus requested a review from a team as a code owner April 10, 2026 22:38
@boringcactus boringcactus requested a review from EmmaSimon April 10, 2026 22:38
Copy link
Copy Markdown
Contributor

@EmmaSimon EmmaSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@boringcactus boringcactus added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 7f10112 Apr 13, 2026
7 checks passed
@boringcactus boringcactus deleted the mth-tvpxrvztxrzr branch April 13, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants