chore(ci): replace mbta/actions/reshim-asdf#775
Open
rwaskiewicz wants to merge 1 commit into
Open
Conversation
2f8b64e to
ab91b15
Compare
Replace `mbta/actions/reshim-asdf` with bash equivalent commands. In the v2.20 release, commit mbta/actions@3579cb7 marked the reshim-asdf action as deprecated. A recent Dependabot update attempted to bump this action's version to v2.21 - while the update would succeed otherwise, replace the action now while it's on top of mind. The existing job structure of the CI workflow has been maintained as-is. In the future, there is room to refactor this to either a composite action or series of parallel steps, which would eliminate the need to pass the `ASDF_DIR` and `ASDF_DATA_DIR` values between jobs. However, since this is an unplanned task created to avoid a deprecated Action, leave that for another day. `asdf-vm/actions/setup` was not used here. While the action can achieve the same effect as the new `asdf_env_setup` step, it did not seem worth it to have to manage an additional dependency for setting up something on our `PATH`. In the future, when Dependabot PRs are grouped and/or the CI workflow is refactored, this can certainly be re-explored (i.e. this is a judgment call more than anything).
ab91b15 to
f8ec30e
Compare
Contributor
Mm, I don't love this, for a few reasons:
Does this sway your judgment? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: N/A
Description
Replace
mbta/actions/reshim-asdfwith bash equivalent commands. Inthe v2.20 release, commit mbta/actions@3579cb7
marked the reshim-asdf action as deprecated. A recent Dependabot update
attempted to bump this action's version to v2.21 - while the update
would succeed otherwise, replace the action now while it's on top of
mind.
(Note: Since we're using tags instead of SHAs for this action, we're technically already using v2.20 (v2 still points at one minor behind as of this writing) in its deprecated state)
The existing job structure of the CI workflow has been maintained as-is.
In the future, there is room to refactor this to either a composite
action or series of parallel steps, which would eliminate the need to
pass the
ASDF_DIRandASDF_DATA_DIRvalues between jobs. However,since this is an unplanned task created to avoid a deprecated Action,
leave that for another day.
asdf-vm/actions/setupwas not used here. While the action can achievethe same effect as the new
asdf_env_setupstep, it did not seem worthit to have to manage an additional dependency for setting up something
on our
PATH. In the future, when Dependabot PRs are grouped and/or theCI workflow is refactored, this can certainly be re-explored (i.e. this
is a judgment call more than anything).