Bump marimo-precompute pin to >=0.3.6#9
Merged
Conversation
Parallel LAMMPS force evaluations accumulate small floating-point differences (~4e-8) due to summation order in domain decomposition, which exceeds np.allclose default atol of 1e-8.
Link to the rendering of notebooks
Contributor
Author
|
Not sure this is quite right yet, hold off merging. Will fix it ASAP. |
0e6d06e to
1374fac
Compare
1374fac to
b57aaa9
Compare
marimo-precompute 0.3.5 is the first 0.3.x release that actually works
under Pyodide. 0.3.0 through 0.3.4 each shipped with at least one WASM
regression (custom loader format changes, threading.Thread refusals in
both restore_cache and save_cache, missing BLOB_DESERIALIZERS import in
marimo 0.23.1) that slipped through an e2e test which pinned to PyPI
instead of testing the local checkout. 0.3.5 includes a new e2e fixture
that builds from wheel and serves locally, so future breakage is caught
in CI.
No notebook code changes needed — none of the demos pass method=
explicitly, and 0.3.5's default ("lazy_precompute") is picked up
automatically. Also gitignore examples/__marimo__/ (local marimo-edit
session artifacts).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
b57aaa9 to
993f90f
Compare
Contributor
Author
|
Verified working end-to-end against the jameskermode/LACT fork's live deploy — safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marimo-precomputePEP 723 pin from>=0.2.3to>=0.3.6in all four demo notebooks.demo1_lj_dimer.wasm.htmletc.).examples/__marimo__/to.gitignore.Why
marimo-precompute0.3.6 is the first 0.3.x release that actually works against the marimo version Pyodide bundles (0.23.1 via conda-forge). The 0.3.x line replaced the old customNumpyJsonLoaderwith a subclass of marimo's new built-inLazyLoader, which took six tries to get right:LazyLoader.restore_cachespawns threads; Pyodide refusesthreading.Thread.start()— override with sequential loaderBLOB_DESERIALIZERSonly exists in marimo 0.23.2+ — replace with inline extension dispatchsave_cacheALSO spawns threads — guard with WASM checkItem.type_hintonly exists in marimo 0.23.2+ — usegetattr(..., None)Upstream now has an e2e parametrised over marimo versions (0.23.1 and current), so a regression like this class of bug should be caught before release.
No notebook code changes needed — none of the demos pass
method=explicitly, and 0.3.6's default ("lazy_precompute") is picked up automatically.Test plan
demo1_lj_dimer.wasm.htmlverified loading in Chromium against the deployed fork (jameskermode.github.io/LACT), 2 images rendered, 0 tracebacks.pip install . marimo-precomputepulls 0.3.6+).🤖 Generated with Claude Code