Conversation
- Added `\u00a7e` (yellow color code) to the "Return" button (`θΏε`) in `ItemShopGui`.
- Updated `GemListener` to use `endsWith("θΏε")` instead of `equals` to correctly identify the modified button.
Co-authored-by: acsoto <59144459+acsoto@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fe2d57329
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ItemMeta meta = icon.getItemMeta(); | ||
|
|
||
| if (meta.hasDisplayName() && meta.getDisplayName().equals("θΏε")){ | ||
| if (meta.hasDisplayName() && meta.getDisplayName().endsWith("θΏε")){ |
There was a problem hiding this comment.
Using endsWith("θΏε") makes the back-navigation handler fire for any shop item whose display name happens to end with those characters, and item names come from configurable ItemStack metadata in this module. In that case, clicking the item now runs /gemshop instead of purchasing it, which is a behavior regression introduced by this commit; matching the stripped name exactly (or exact colored label) avoids false positives.
Useful? React with πΒ / π.
1 participant
π‘ What: Added the yellow color code (
\u00a7e) to the "Return" button (θΏε) in the GemShop GUI, and updated the corresponding click listener to useendsWith()instead of exact string matching.π― Why: To bring the GemShop's "Return" button UX inline with the visual standard established by other GUIs across the server (e.g., AcShop, MedalCabinet), making the button stand out as a distinct interactive element rather than a regular item.
βΏ Accessibility/UX: Improved visual distinction for navigation elements in the Spigot GUI.
PR created automatically by Jules for task 12504575842787894449 started by @acsoto