-
Notifications
You must be signed in to change notification settings - Fork 0
feat(web): app shell, router, theme (PLAN §4.3) #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| description: Named exports only in TypeScript; no default exports | ||
| globs: | ||
| - "**/*.ts" | ||
| - "**/*.tsx" | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| # No default exports (TypeScript) | ||
|
|
||
| - Prefer **named exports** only: `export const Component = …`, `export { foo }`, and similar. | ||
| - Do **not** add `export default`, including `export { Name as default }`, unless the file is an allowed tooling entrypoint (see below). | ||
|
|
||
| **Exception:** `apps/web/vite.config.ts` and `apps/web/openapi-ts.config.ts` may use `export default` because Vite and `@hey-api/openapi-ts` load the config via the module’s default export. Biome disables `style/noDefaultExport` for those paths in `apps/web/biome.json`. | ||
|
|
||
| Where this repository runs Biome with `style.noDefaultExport`, that config applies to the linted tree (see `apps/web/biome.json`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,12 @@ | ||
| import { createSignal } from 'solid-js'; | ||
| import './App.css'; | ||
| import { Route, Router } from '@solidjs/router'; | ||
| import type { JSX } from 'solid-js'; | ||
| import { AppShell } from './layout/AppShell'; | ||
| import { Home } from './pages/Home'; | ||
| import { RecipePage } from './pages/RecipePage'; | ||
|
|
||
| function App() { | ||
| const [count, setCount] = createSignal(0); | ||
|
|
||
| return ( | ||
| <main class="app"> | ||
| <h1>Bread Recipes</h1> | ||
| <p class="lede"> | ||
| SolidJS + Vite scaffold (PLAN §4.1). Replace this with the real UI in | ||
| later tasks. | ||
| </p> | ||
| <button | ||
| type="button" | ||
| class="counter" | ||
| onClick={() => setCount((c) => c + 1)} | ||
| > | ||
| Count is {count()} | ||
| </button> | ||
| </main> | ||
| ); | ||
| } | ||
|
|
||
| export default App; | ||
| export const App = (): JSX.Element => ( | ||
| <Router root={AppShell}> | ||
| <Route path="/" component={Home} /> | ||
| <Route path="/recipes/:id" component={RecipePage} /> | ||
| </Router> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| /* @refresh reload */ | ||
| import type { JSX } from 'solid-js'; | ||
| import { render } from 'solid-js/web'; | ||
| import './index.css'; | ||
| import App from './App.tsx'; | ||
| import { App } from './App.tsx'; | ||
|
|
||
| const root = document.getElementById('root'); | ||
| const root: HTMLElement | null = document.getElementById('root'); | ||
| if (!root) { | ||
| throw new Error('Missing #root element'); | ||
| } | ||
|
|
||
| render(() => <App />, root); | ||
| render((): JSX.Element => <App />, root); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--accent-hoveris defined here (and in the dark-scheme override) but isn’t used anywhere in the current styles. Consider either using it for hover states (e.g., link hover colors) or removing it to avoid carrying unused design tokens.