Conversation
git-subtree-dir: ai-resources git-subtree-split: 6b1190a470dd9348f9a1a058d444d4359f294887
There was a problem hiding this comment.
Pull request overview
Adds a shared ai-resources/ git subtree containing Claude rules and skills, then wires it into this repo via a root CLAUDE.md include and updated ignore rules so local AI tool state isn’t committed.
Changes:
- Add
ai-resources/subtree with rules (rules/) and skills (skills/). - Add root
CLAUDE.mdthat imports@ai-resources/CLAUDE.md. - Ignore
.claudeworkspace state via.gitignore(and subtree-local ignore).
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ai-resources/skills/md2pdf/md-to-pdf.config.js | Adds shared md-to-pdf config (styling + footer template). |
| ai-resources/skills/md2pdf/SKILL.md | Documents a /md2pdf skill using the bundled config. |
| ai-resources/skills/link-skills/SKILL.md | Adds a skill to symlink subtree skills into .claude/skills/. |
| ai-resources/skills/fix-vulns/SKILL.md | Adds a skill describing a pnpm audit → fix → PR workflow. |
| ai-resources/rules/zsh-bash-commands.md | Adds guidance for running commands via zsh -i -c. |
| ai-resources/rules/pull-requests.md | Adds PR creation/cleanup guidance. |
| ai-resources/rules/general.md | Adds general AI workflow rules (scope control, British English, etc.). |
| ai-resources/rules/conventional-commits.md | Adds Conventional Commits guidance. |
| ai-resources/rules/conventional-branch-names.md | Adds Conventional Branch Names guidance. |
| ai-resources/rules/code-organisation.md | Adds code organisation/testing placement guidelines. |
| ai-resources/rules/all.md | Aggregates rules via @... includes. |
| ai-resources/README.md | Documents how to consume/update the subtree and link skills. |
| ai-resources/CLAUDE.md | Entry point to import all rules + skills in the subtree. |
| ai-resources/AGENTS.md | Provides Codex instructions by delegating to CLAUDE.md. |
| ai-resources/.gitignore | Ignores .claude/ within the subtree context. |
| CLAUDE.md | Imports the subtree’s CLAUDE.md to enable shared rules/skills. |
| .gitignore | Ignores .claude directory at repo root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const generatedAt = new Date().toLocaleString(); | ||
| const inputFilename = path.basename(process.argv[process.argv.length - 1]); |
There was a problem hiding this comment.
inputFilename is interpolated directly into an HTML footer template. Filenames can legally contain characters like &, <, or > which will be interpreted as HTML and can break the footer rendering. Consider HTML-escaping inputFilename (and any other interpolated values) before inserting them into footerTemplate.
| # All Rules | ||
|
|
||
| @general.md | ||
| @zsh-node-commands.md |
There was a problem hiding this comment.
@zsh-node-commands.md is referenced here, but there is no such file under ai-resources/rules/ (the only matching rule file is zsh-bash-commands.md). As written, importing @rules/all.md (and therefore @ai-resources/CLAUDE.md) will fail; update the reference or rename the rule file so the include resolves.
| @zsh-node-commands.md | |
| @zsh-bash-commands.md |
| # Running Commands with the `bash` shell | ||
|
|
||
| When running commands in the `bash` shell: | ||
|
|
||
| ```sh | ||
| zsh -i -c "..." | ||
| ``` |
There was a problem hiding this comment.
This rule says it is about running commands with the bash shell, but the recommended invocation is zsh -i -c "..." and the rationale references .zshrc. Please clarify whether this rule is about the Claude bash tool (which may execute via zsh for nvm) or about zsh itself, and update the heading/wording accordingly to avoid confusion.
Summary
ai-resourcesas a git subtree, providing shared Claude rules and skillsCLAUDE.mdreferencingai-resources/CLAUDE.mdto wire up the rules.gitignoreto accommodate the new subtreeTest plan
ai-resources/directory is present with all expected filesCLAUDE.mdresolves correctly toai-resources/CLAUDE.mdfix-vulns,link-skills,md2pdf) are accessible🤖 Generated with Claude Code