Skip to content
This repository was archived by the owner on Dec 8, 2025. It is now read-only.

fix: import parser properly delegates to resource location parser#37

Merged
vberlier merged 2 commits intomcbeet:mainfrom
TheWii:main
Aug 12, 2022
Merged

fix: import parser properly delegates to resource location parser#37
vberlier merged 2 commits intomcbeet:mainfrom
TheWii:main

Conversation

@TheWii
Copy link
Copy Markdown
Contributor

@TheWii TheWii commented Aug 12, 2022

I noticed that the bolt:import parser uses parsers["resource_location_or_tag"] to get the resource_location_or_tag parser (instead of using the delegate function), making it impossible to be overridden.

@vberlier
Copy link
Copy Markdown
Member

Yeah I think using delegate would be desirable here but you need to wrap it with DisableInterpolationParser since bolt overrides resource_location_or_tag to enable interpolation.

@vberlier vberlier merged commit a971b07 into mcbeet:main Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants