Skip to content

Conversation

@Plagiatus
Copy link
Collaborator

created central page layout to be applied to all pages of the manager, added stub for mention-legale content, added links to said content.

  • central page layout means I also cleaned up some unnecessarily nested components

- central page layout means I also cleaned up some unnecessarily nested components
@Plagiatus Plagiatus linked an issue Feb 25, 2025 that may be closed by this pull request
Add mentions légales
@theogiraudet
Copy link
Contributor

@aksiome can you check the result?
@Aeris1One can you check the content?

@aksiome aksiome marked this pull request as ready for review February 26, 2025 20:10
@aksiome
Copy link
Member

aksiome commented Feb 26, 2025

Hey @Plagiatus, sorry I didn't mention earlier that I was working on a refactor. I couldn’t resist trying out Svelte when i worked on the style, and upgrading to Svelte 5 seemed like the perfect excuse 😅. Mostly, I moved some code around, fixed the theme selector local storage, and tweaked the style and HTML markup.

@Plagiatus
Copy link
Collaborator Author

Plagiatus commented Feb 27, 2025

no worries, it didn't take too much time. Should I set up the layout & page again or are you going to do that?
Because it seems your merge pretty much undid all the things I did (set up the central layout, actually link to the relevant page in the relevant places, etc).

@aksiome
Copy link
Member

aksiome commented Feb 27, 2025

no worries, it didn't take too much time. Should I set up the layout & page again or are you going to do that? Because it seems your merge pretty much undid all the things I did (set up the central layout, actually link to the relevant page in the relevant places, etc).

No, don't worry about that! I copied what you did with the layout during the merge resolution, so it should be fine.

@aksiome aksiome merged commit 41310f2 into main Feb 28, 2025
@aksiome aksiome deleted the legale-page branch February 28, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Mention Légale" page

5 participants