-
-
Notifications
You must be signed in to change notification settings - Fork 23
toggle explorer instead of opening a new one #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you! |
|
@jarun uhhh, the PR wasn't ready for merge yet 😅 . Wanted some more testing in case there's some weird quirk that happens on vim but not nvim and vice versa. Welp, shouldn't be a big deal. If there's some quirk/problem, we can fix it on the go. |
|
Use the label |
|
Don't think I can add labels, which is why I put |
I believe you should be able to create a draft PR? |
I'll try that next time. Anyways, since it's already merged don't think the label is needed. And it works fine for all "basic" usecases from what I've tested (both vim and nvim), so this should be fine. |
|
Thanks, I'm in. |
| let s:nnn_conf_dir = (!empty($XDG_CONFIG_HOME) ? $XDG_CONFIG_HOME : $HOME.'/.config') . '/nnn' | ||
| " The fifo used by the persistent explorer | ||
| let s:explorer_fifo = "" | ||
| let t:explorer_winid = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need to initialize this immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's leftover from earlier state. I'll clean it up and document the changes on a separate PR.
|
Closing the explorer pane by means other than running Alternatively I suppose you could clear the tabpage var in the |
|
@luukvbaal Yes, moving that in |
This makes it so running
:NnnExplorerwhile an explorer window is already open toggle/close it instead of opening a new explorer window.Undocumented, also might need more testing (on both vim and neovim) before merge.