Skip to content

Fix any issues related to explorer-toggle#140

Merged
mcchrish merged 4 commits intomcchrish:masterfrom
N-R-K:ex_toggle
Nov 1, 2021
Merged

Fix any issues related to explorer-toggle#140
mcchrish merged 4 commits intomcchrish:masterfrom
N-R-K:ex_toggle

Conversation

@N-R-K
Copy link
Copy Markdown
Collaborator

@N-R-K N-R-K commented Nov 1, 2021 •
edited
Loading

  • quitting explorer normally doesn't clear explorer_winid (13f1794)
  • on vim :NnnExplorer ends up closing the current buffer as well as the explorer buffer. (doesn't happen on nvim) (b7bae69)
  • triggering the above also leads to opening up multiple explorer instances (b7bae69)

@N-R-K N-R-K marked this pull request as draft November 1, 2021 05:14
@N-R-K
Copy link
Copy Markdown
Collaborator Author

N-R-K commented Nov 1, 2021 •
edited
Loading

Aright, all the known issues should be fixed now. Still keeping it [WIP] in case someone finds more.

@mcchrish
Copy link
Copy Markdown
Owner

mcchrish commented Nov 1, 2021

Working fine for me so far.

@N-R-K N-R-K marked this pull request as ready for review November 1, 2021 09:05
@N-R-K N-R-K added bug Something isn't working and removed work in progress labels Nov 1, 2021
@N-R-K N-R-K requested a review from mcchrish November 1, 2021 10:05
@mcchrish mcchrish merged commit 384ffa0 into mcchrish:master Nov 1, 2021
@N-R-K N-R-K deleted the ex_toggle branch November 1, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcchrish mcchrish mcchrish approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@N-R-K @mcchrish