Skip to content

Simply map <c-w> to normal mode <c-w>#144

Merged
mcchrish merged 2 commits intomasterfrom
simply-map-c-w
Nov 3, 2021
Merged

Simply map <c-w> to normal mode <c-w>#144
mcchrish merged 2 commits intomasterfrom
simply-map-c-w

Conversation

@mcchrish
Copy link
Copy Markdown
Owner

@mcchrish mcchrish commented Nov 2, 2021

I think we can just map to normal mode that wall all will just work not just the four mappings we created.

Also I think it make sense that it should always be mapped regardless of set_default_mappings. set_default_mappings is if they want to get rid of <leader>n.

@N-R-K
Copy link
Copy Markdown
Collaborator

N-R-K commented Nov 2, 2021

The change looks good. Although I feel like it should be guarded by some config var in case someone wants to use some other binding to .

But if we want to remove the guard and enable it all the time, then we'll have to update the docs on that as well.

Comment thread doc/nnn.txt
@mcchrish
Copy link
Copy Markdown
Owner Author

mcchrish commented Nov 3, 2021

I'm wondering if it also makes sense to map : to normal mode :. It's common enough to be added as default. What do you think?
Also are there more default mappings that can be handy?

@N-R-K
Copy link
Copy Markdown
Collaborator

N-R-K commented Nov 3, 2021

I'm wondering if it also makes sense to map : to normal mode :. It's common enough to be added as default. What do you think?

I was actually thinking about this as well. nnn doesn't seem to have any default binding set to : so it should be okay.

@mcchrish mcchrish requested a review from N-R-K November 3, 2021 06:56
@mcchrish
Copy link
Copy Markdown
Owner Author

mcchrish commented Nov 3, 2021

I realized it might not be ideal to map :. It will be triggered even during times like renaming/creating files or any other state nnn is in.

Copy link
Copy Markdown
Collaborator

@N-R-K N-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also like that <C-w> is configureable. Despite using very few plugins I've still encountered issues where a plugin was colluding with my keybinding so I'm always in favor of making things configureable.

@mcchrish mcchrish merged commit 0972149 into master Nov 3, 2021
@mcchrish mcchrish deleted the simply-map-c-w branch November 3, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants