Conversation
|
The change looks good. Although I feel like it should be guarded by some config var in case someone wants to use some other binding to . But if we want to remove the guard and enable it all the time, then we'll have to update the docs on that as well. |
0580d7d to
0f30b02
Compare
|
I'm wondering if it also makes sense to map |
I was actually thinking about this as well. |
|
I realized it might not be ideal to map |
N-R-K
left a comment
There was a problem hiding this comment.
Looks good. Also like that <C-w> is configureable. Despite using very few plugins I've still encountered issues where a plugin was colluding with my keybinding so I'm always in favor of making things configureable.
I think we can just map to normal mode that wall all will just work not just the four mappings we created.
Also I think it make sense that it should always be mapped regardless of
set_default_mappings.set_default_mappingsis if they want to get rid of<leader>n.