Fix of Single_crystal reuse optimization #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocity vector would reuse wrong data from previous neutron. Allocated a seperate data structure for the initial search for reflections which avoids this issue. Fixed a test to be sensitive to such an issue in the future.
Contributor
|
@mads-bertelsen thanks. Actual feedback to this might not arrive until ~ November since busy with other stuff. :-) |
Contributor
Author
|
No worries! Now the issue is visible and a fix available to those who need it quick. |
Contributor
|
Merging this solution for now - deferring GPU uservars solution until later, as also mentioned in #1725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue in Single_crystal where neutrons with similar initial velocity vector would reuse wrong data from previous neutron. Allocated a seperate data structure for the initial search for reflections which avoids this issue. Fixed a test to be sensitive to such an issue in the future.
Suggestions on how to make this GPU compatible have been made, so this PR should not be merged yet.