Skip to content

Conversation

@mads-bertelsen
Copy link
Contributor

@mads-bertelsen mads-bertelsen commented Dec 8, 2025

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:
Tiny pull request with two small fixes:

Fixed issue causing verbal mode of Union master to not compile as a variable was not declared.
Fixed formating in debug printf in Union master.
Removed debug print in union-lib.c function.

Still has few linter outputs related to the mesh component that will be addressed separately.


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
OS X


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes patches to an existing component file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)
    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have used the mctest utility to test one or more instruments making use of the component (please attach mcviewtest report as screenshot in comments)
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised

@willend
Copy link
Contributor

willend commented Dec 8, 2025

@mads-bertelsen thanks, merging!

@willend willend merged commit f25d470 into main Dec 8, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants