Conversation
…input in Phonon_simple
…input in Phonon_simple rebase phonon_focusing_fix to be from updated main
…cCode into phonon_focusing_fix
…honon simple comp
|
@willend I am quite sure this is ready to be pulled. The test screenshot is missing, but as far as I understand, this has already been done by the CI correctly? |
|
@Lomholy actually the best is to also run a local 'mcviewtest' e.g. on the outputs of the CI (e.g. https://github.com/mccode-dev/McCode/actions/runs/22348263409?pr=2343). I am working toward a solution that will bring up the "result matrix" automatically but don't have that in place just yet. |
|
@willend Just tried, but when I am at the directory where the Samples_Phonon.instr is, and I run `loading system configuration Adding instruments from subfolders in: /Users/tqv636/Desktop/Phd/McCode/mcstas-comps/examples/Tests_samples/Samples_Phonon WARNING: Skipped Samples_Phonon test - did /Users/tqv636/Desktop/Phd/McCode/mcstas-comps/examples/Tests_samples/Samples_Phonon/mcstas-test_20260316_1729_28/mcstas-3.6.8_Samples_Phonon.instr_Darwin_LOCAL/Samples_Phonon exist already?? Compiling instruments [seconds]... Running tests / getting status... After which i do mcviewtest inside the folder created, and it seems like no test was run:
What do you reckon might be the problem? |
|
Will do final review of code and doc comments etc. tomorrow |
|
@Lomholy just realised that this was the “smaller” contribution - so will just go ahead and merge now. |




Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Added in a conversion from Degrees to radians inside the initialize of Phonon_simple, such that it is consistent with its header.
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
MacOS Tahoe 26.3
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes patches to an existing component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mctestutility to test one or more instruments making use of the component (please attachmcviewtestreport as screenshot in comments)mccode-clangformattool to apply the standard McCode component indentation schememcrun --c-lint"linter" and followed advice to remove most / all warnings that are raised